Am I getting somewhere?
Create a merge request here: https://gitlab.com/graphviz/graphviz/-/merge_requests/new.
I’m pretty happy with changing xlink:href to href, that seems straightforward, though will probably need some test suite updates.
I’m not keen on applying the class both to the anchor and the group. I expect this will probably break some stylesheets that assign properties to the group, and think it’ll only apply to the group. I think if you want to apply a class to the anchor, perhaps we should post-process the output or use another property name, like anchor_class or url_class or href_class.
Your merge request link doesn’t work for me, which would explain why I got nowhere trying to find it.
There aren’t many xlink:hrefs being generated and mostly for non-anchors, but a lot of tests for cases not possibly generated by anything graphviz does. Looks mostly like cairo and/or windows cases. How to handle those?
Yeah, thinking and studying it more, I agree with your “anchor_class=” proposal, since it’s the anchor getting the annotation, and all I’m trying to get is "class="internal-link" on the anchor. I think I made a mess adding the “obsidianinternallink=true” option in my previous draft. What’s the right way to do it? Other things besides nodes have href=, and conflating href with url seems like something to avoid?
Whoops, maybe you should try this link: https://gitlab.com/wagle/graphviz/-/merge_requests/new.
Also not found.
Oh gosh, sorry to mess you around. I mistook your github name for gitlab name.
Try:
Oh, yeah that. Someone grabbed “wagle” before I got around to it. Sorry, its throwing me off too.
Whats the target supposed to be?
Trying a different way.
Currently fumbling about trying to get CLion to play well with gitlab. I think I’ll be a while.
Target should be graphviz/graphviz
I had an alter ego (alternate ssh identity) getting in the way. I forgot all about that. Sorry.
I marked it as a draft, so " Merge blocked: merge request must be marked as ready. It’s still marked as draft.".
Agenda item: decide how to handle deprecating
xlink:href=. Do both or justhref=?
Should I go ahead and figure out the testing harness, or wait for people to give this a quick whirl?
Should I start another thread to discuss how to do class= for anchors, or remain in this one?